Improve bound and cache update checks #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
bound-checks
branch
from
af7c2cf to
1acc9af
Compare
tamirms
reviewed
Jan 9, 2025
tamirms
reviewed
Jan 9, 2025
Co-authored-by: tamirms <[email protected]>
Shaptic
reviewed
Jan 9, 2025
Shaptic
reviewed
Jan 22, 2025
Shaptic
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Looks like there's a test failing so pls fix that first but otherwise this LGTM:
get_events_test.go:436:
Error Trace: /home/runner/work/stellar-rpc/stellar-rpc/cmd/stellar-rpc/internal/methods/get_events_test.go:436
Error: Error message not equal:
expected: "startLedger must be positive"
actual : "startLedger must be positive and <= than endLedger"
Test: TestGetEventsRequestValid
acd480f to
6f75d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.